Fix build out of the box #59

Trinkes · 2019-02-16T01:00:08Z

This PR includes 2 new files on .gitignore file:
1 - idea cache file
2 - idea modules file (can be ignored as described here)

Also, it allows everyone to make a build out of the box without having to defile values like "RELEASE_APP_ID"

v1.3.2

v1.3.3

…ut of the box

Trinkes · 2019-02-16T01:02:25Z

My branch started from master, did you have any commit on master missing on dev?

b-lam

@Trinkes Looks good to me! I don't really have time to test it right now but I'm just gonna merge it in and fix any complications down the line. Thanks for doing this!

* Update README.md * update gitignore file to ignore idea cache and modules files * create default values to the needed keys in order to allow building out of the box

b-lam and others added 5 commits February 3, 2019 13:06

Merge pull request b-lam#56 from b-lam/develop

63666cc

v1.3.2

Merge pull request b-lam#58 from b-lam/develop

60c0684

v1.3.3

Update README.md

c29f88c

update gitignore file to ignore idea cache and modules files

fe41b0d

create default values to the needed keys in order to allow building o…

77909b9

…ut of the box

b-lam approved these changes Feb 16, 2019

View reviewed changes

b-lam merged commit 8062828 into b-lam:develop Feb 16, 2019

b-lam added a commit that referenced this pull request Feb 16, 2019

Fix build out of the box (#59) (#60)

a4cd485

* Update README.md * update gitignore file to ignore idea cache and modules files * create default values to the needed keys in order to allow building out of the box

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix build out of the box #59

Fix build out of the box #59

Trinkes commented Feb 16, 2019

Trinkes commented Feb 16, 2019

b-lam left a comment

Fix build out of the box #59

Fix build out of the box #59

Conversation

Trinkes commented Feb 16, 2019

Trinkes commented Feb 16, 2019

b-lam left a comment

Choose a reason for hiding this comment