Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks
Status
Stable. Review will be appreciated.
Changes
getRequestData()
now completely controls analysis data arranging process (that was partial due to Armlet's older interface).getMythXReport()
isasync
now because must control a lot of asynchronous remote actions, provided by MythXJS.--version
CLI option/switch.--help
CLI option/switch.getRequestData()
andgetMythXReport()
.mythxSpinner
toanalysisSpinner
.Notes
--noCacheLookup
parameter, so it will need additional fix. I've created a PR for it: Add support for noCacheLookup API parameter Consensys/mythxjs#24. When it will be merged, we will need to recheck current behavior.async
/await
.Regards, @blitz-1306.