Validate all known, validatable methods by default in liberator-mixin…

….validation.

CHANGELOG.md

@@ -8,6 +8,9 @@ and this project adheres to
 
 
 ## [Unreleased]
+### Changed
+- Validate all known, validatable methods by default in 
+  `liberator-mixin.validation`.
 
 ## [0.0.28] — 2019-09-16
 ### Changed

src/liberator_mixin/validation/core.clj

@@ -15,14 +15,14 @@
 
 (defn with-validation []
   {:validate-methods
-   [:put :post]
+   (fn [{:keys [resource]}] ((:known-methods resource)))
 
    :processable?
    (fn [{:keys [resource request] :as context}]
      (if-let [new-validator (get resource :validator)]
        (let [validate-methods (get resource :validate-methods)
              request-method (get request :request-method)]
-         (if (some #(= request-method %) (validate-methods))
+         (if (some #(= request-method %) (validate-methods context))
            (valid? (new-validator context) context)
            true))
        true))

test/liberator_mixin/validation/core_test.clj

@@ -45,6 +45,26 @@
       (is (= 200 (:status response)))
       (is (= "OK" (get-in response [:body :status])))))
 
+  (testing "validates all known methods (except options) by default"
+    (doseq [method #{:get :head :put :patch :spinach}]
+      (let [resource
+            (core/build-resource
+              (json/with-json-media-type)
+              (validation/with-validation)
+              {:known-methods   [:get :head :put :patch :options :spinach]
+               :allowed-methods [:get :head :put :patch :options :spinach]
+               :validator       (new-mock-validator false nil)}
+              {:handle-created (constantly {:status "OK"})
+               :handle-ok      (constantly {:status "OK"})})
+            response (call-resource
+                       resource
+                       (->
+                         (ring/request method "/")
+                         (ring/header :content-type json/json-media-type)
+                         (ring/body {:key "value"})))]
+        (is (= 422 (:status response))
+          (str "Method: " method)))))
+
   (testing "does not validate request if not included in validate-methods"
     (let [resource (core/build-resource
                      (json/with-json-media-type)