New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add $pageId parameter to getPreviewUrl() #15

Closed

daso-lw wants to merge 2 commits into b13:master from daso-lw:page-preview-url

daso-lw commented Nov 2, 2022

Instead of always creating a preview URL for the site's language base URL, allow providing a page ID to generate a specific page's URL.

daso-lw added 2 commits

November 2, 2022 15:52


          Add $pageId parameter to getPreviewUrl()

492be7d


          Create "generatePreviewUrlForPage" and separate these methods

14dc9f8

Collaborator

ervaude commented Nov 4, 2022

Hi @daso-lw
good hearing from you. Thanks for the suggestion. I implemented the feature with #16

Please let me know if this works for you.

Cheers
Daniel

ervaude closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment