Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mrcm): Include unapproved attributes in search for applicable types #1179

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

AAAlinaaa
Copy link
Contributor

No description provided.

@AAAlinaaa AAAlinaaa self-assigned this Jun 26, 2023
Copy link
Member

@cmark cmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥓

@cmark cmark requested review from apeteri and nagyo June 26, 2023 14:25
Copy link
Member

@apeteri apeteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch coverage: 50.00% and no project coverage change.

Comparison is base (909c633) 63.97% compared to head (956cb45) 63.98%.

Additional details and impacted files
@@            Coverage Diff            @@
##                8.x    #1179   +/-   ##
=========================================
  Coverage     63.97%   63.98%           
- Complexity    12790    12792    +2     
=========================================
  Files          1764     1764           
  Lines         59721    59721           
  Branches       5520     5520           
=========================================
+ Hits          38209    38213    +4     
  Misses        19133    19133           
+ Partials       2379     2375    -4     
Impacted Files Coverage Δ
...nomed/datastore/request/SnomedMrcmTypeRequest.java 75.00% <50.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@nagyo nagyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍏

@nagyo nagyo merged commit 659fe63 into 8.x Jun 26, 2023
4 of 5 checks passed
@nagyo nagyo deleted the issue/SO-5826-mrcm-bug-fixes branch June 26, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants