Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SO-5834: generic dependency model #1188

Merged
merged 26 commits into from Jul 27, 2023
Merged

Conversation

cmark
Copy link
Member

@cmark cmark commented Jul 11, 2023

No description provided.

Old extensionOf and upgradeOf parameters are being converted to the new
model and persisted.
Support extensionOf/upgradeOf and the new dependency array in all
TerminologyResource subtypes.
@cmark cmark added the feature label Jul 11, 2023
@cmark cmark requested a review from apeteri July 11, 2023 15:40
@cmark cmark self-assigned this Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Patch coverage: 83.06% and project coverage change: +0.13% 🎉

Comparison is base (7b4c7c2) 64.03% compared to head (13d467b) 64.16%.
Report is 6 commits behind head on 8.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                8.x    #1188      +/-   ##
============================================
+ Coverage     64.03%   64.16%   +0.13%     
- Complexity    12809    12926     +117     
============================================
  Files          1764     1774      +10     
  Lines         59885    60158     +273     
  Branches       5529     5560      +31     
============================================
+ Hits          38348    38602     +254     
- Misses        19157    19174      +17     
- Partials       2380     2382       +2     
Files Changed Coverage Δ
...2international/index/es/query/Es8QueryBuilder.java 0.00% <0.00%> (ø)
...ional/snowowl/core/rest/BaseResourceRestInput.java 85.71% <ø> (ø)
...snowowl/core/rest/BaseResourceUpdateRestInput.java 100.00% <ø> (ø)
...nowowl/core/bundle/BundleSearchRequestBuilder.java 100.00% <ø> (ø)
...owowl/core/codesystem/CodeSystemCreateRequest.java 100.00% <ø> (ø)
...ore/codesystem/CodeSystemSearchRequestBuilder.java 100.00% <ø> (ø)
...owowl/core/codesystem/CodeSystemUpdateRequest.java 100.00% <ø> (ø)
...nowowl/core/request/BaseResourceCreateRequest.java 88.57% <ø> (ø)
...re/request/resource/BaseResourceSearchRequest.java 88.59% <ø> (ø)
...est/resource/BaseResourceSearchRequestBuilder.java 83.33% <ø> (ø)
... and 37 more

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmark cmark marked this pull request as ready for review July 18, 2023 07:43
@cmark cmark requested a review from nagyo July 18, 2023 07:44
Copy link
Member

@apeteri apeteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@apeteri apeteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@apeteri
Copy link
Member

apeteri commented Jul 24, 2023

Does snow-owl-ext need a separate PR or is everything handled in classes of this project?

@cmark
Copy link
Member Author

cmark commented Jul 24, 2023

Does snow-owl-ext need a separate PR or is everything handled in classes of this project?

There is an open PR in that repo: https://github.com/b2ihealthcare/snow-owl-ext/pull/2681

@cmark cmark requested a review from AAAlinaaa July 25, 2023 09:50
Copy link
Contributor

@AAAlinaaa AAAlinaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmark cmark merged commit 6da3d20 into 8.x Jul 27, 2023
5 checks passed
@cmark cmark deleted the feature/SO-5834-dependencies-model branch July 27, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants