feat(classification): resurrect cd member inference #1302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Older systems with member based concrete domain support (via the concreteDomainSupport configuration setting) should be able to keep their inferred concrete data values in cd members (as opposed to moving them to the new relationship value model which has limited support for data types).
apeteri
approved these changes
Jun 26, 2024
...reasoner/src/com/b2international/snowowl/snomed/reasoner/normalform/NormalFormGenerator.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 9.x #1302 +/- ##
============================================
- Coverage 48.47% 48.45% -0.03%
Complexity 14027 14027
============================================
Files 1948 1949 +1
Lines 95292 95343 +51
Branches 11011 11020 +9
============================================
+ Hits 46194 46197 +3
- Misses 46063 46110 +47
- Partials 3035 3036 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older systems with member based concrete domain support (via the concreteDomainSupport configuration setting) should be able to keep their inferred concrete data values in cd members (as opposed to moving them to the new relationship value model which has limited support for data types).
NOTE: Test cases will arrive in a separate PR.
https://snowowl.atlassian.net/browse/SO-6164