Skip to content

Commit

Permalink
Merge branch '2.0' into 2.1
Browse files Browse the repository at this point in the history
  • Loading branch information
vincent4vx committed Jan 3, 2023
2 parents e62268e + e332e7c commit 52de300
Show file tree
Hide file tree
Showing 7 changed files with 38 additions and 10 deletions.
12 changes: 6 additions & 6 deletions src/Console/HydratorGenerationCommand.php
Expand Up @@ -137,7 +137,7 @@ private function configureOutputs($io): void
*/
private function generateHydrator($io, $className, Mapper $mapper): void
{
$io->inline("Generate hydrator for ${className} ");
$io->inline("Generate hydrator for {$className} ");

try {
$generator = new HydratorGenerator($this->locator, $mapper, $className);
Expand Down Expand Up @@ -185,26 +185,26 @@ private function generateLoader($io): void
$embeddeds = $className::embeddedPrimeClasses();

if (empty($embeddeds)) {
$hydrators[] = "'{$className::supportedPrimeClassName()}' => new ${className}(),";
$hydrators[] = "'{$className::supportedPrimeClassName()}' => new {$className}(),";
} else {
$arguments = [];

foreach ($embeddeds as $entity) {
$arguments[] = "\$registry->get('${entity}')";
$arguments[] = "\$registry->get('{$entity}')";
}

$arguments = implode(', ', $arguments);
$closure = "function(\$registry) {return new ${className}(${arguments});}";
$closure = "function(\$registry) {return new {$className}({$arguments});}";

$factories[] = "'{$className::supportedPrimeClassName()}' => ${closure},";
$factories[] = "'{$className::supportedPrimeClassName()}' => {$closure},";
}
}

$content = "<?php\n";

if ($io->option('include')) {
foreach ($includes as $file) {
$content .= "require_once __DIR__.DIRECTORY_SEPARATOR.'${file}';\n";
$content .= "require_once __DIR__.DIRECTORY_SEPARATOR.'{$file}';\n";
}
} else {
$io->block([
Expand Down
2 changes: 1 addition & 1 deletion src/Schema/Inflector/SimpleInfector.php
Expand Up @@ -43,6 +43,6 @@ public function getPropertyName(string $table, string $field): string
*/
public function getSequenceName(string $table): string
{
return "${table}_seq";
return "{$table}_seq";
}
}
5 changes: 3 additions & 2 deletions tests/Query/ExpressionTest.php
Expand Up @@ -15,7 +15,8 @@ class ExpressionTest extends TestCase

protected $repository;
protected $query;

protected $table;

protected function setUp(): void
{
$this->primeStart();
Expand Down Expand Up @@ -143,4 +144,4 @@ public function test_match_expression_in_boolean_mode()
->toSql()
);
}
}
}
1 change: 1 addition & 0 deletions tests/Query/QueryOrmTest.php
Expand Up @@ -32,6 +32,7 @@ class QueryOrmTest extends TestCase

protected $repository;
protected $query;
protected $table;

/**
*
Expand Down
8 changes: 8 additions & 0 deletions tests/Sharding/Query/ShardingInsertQueryTest.php
Expand Up @@ -27,6 +27,14 @@ class ShardingInsertQueryTest extends TestCase
* @var ShardingConnection
*/
private $connection;
/**
* @var ShardingConnectionFactory
*/
private $factory;
/**
* @var ConnectionRegistry
*/
private $registry;

/**
*
Expand Down
9 changes: 9 additions & 0 deletions tests/Sharding/Query/ShardingKeyValueQueryTest.php
Expand Up @@ -26,6 +26,15 @@ class ShardingKeyValueQueryTest extends TestCase
*/
private $connection;

/**
* @var ShardingConnectionFactory
*/
private $factory;
/**
* @var ConnectionRegistry
*/
private $registry;

/**
* @var ConnectionInterface
*/
Expand Down
11 changes: 10 additions & 1 deletion tests/Sharding/ShardingConnectionTest.php
Expand Up @@ -24,7 +24,16 @@ class ShardingConnectionTest extends TestCase

/** @var ConnectionManager $connections */
protected $connections;


/**
* @var ShardingConnectionFactory
*/
private $factory;
/**
* @var ConnectionRegistry
*/
private $registry;

/**
*
*/
Expand Down

0 comments on commit 52de300

Please sign in to comment.