🔧 added first draft of release files #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JannikStreek
force-pushed
the
27-create-release-docker
branch
from
e99b4be
to
2a9b9ee
Compare
gerardo-navarro
approved these changes
Jan 30, 2021
config/prod.exs
Outdated
| @@ -51,4 +51,4 @@ config :logger, level: :info | |||
|
|
|||
| # Finally import the config/prod.secret.exs which loads secrets | |||
| # and configuration from environment variables. | |||
| import_config "prod.secret.exs" | |||
| # import_config "prod.secret.exs" | |||
There was a problem hiding this comment.
Have you tried running the local phoenix server in prod env, i.e. MIX_ENV=prod mix phx.server.
This failed when I tried executing this locally because database credentials were missing. We should enable this.
| @@ -2,18 +2,42 @@ | |||
| # from environment variables. You can also hardcode secrets, | |||
There was a problem hiding this comment.
As mentioned in previous remark, we should also define the ENV variables in config/prod.exs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #27