Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toasts where sensible #288

Closed
sorenjohanson opened this issue Jun 17, 2024 · 1 comment · Fixed by #294
Closed

Add toasts where sensible #288

sorenjohanson opened this issue Jun 17, 2024 · 1 comment · Fixed by #294
Labels
enhancement New feature or request

Comments

@sorenjohanson
Copy link
Contributor

Proposed feature
In #284, we've added the ngx-toastr package to display a toast when successfully duplicating a mindmap. We should check where else toasts are sensible and add them.

@sorenjohanson sorenjohanson added the enhancement New feature or request label Jun 17, 2024
@JannikStreek
Copy link
Member

JannikStreek commented Jun 18, 2024

I would suggest to add toasts on all actions where it is currently not really clear that something happened. Two ideas at least:

  • When the share url copy button is pressed inside the share modal. Currently only the url is highlighted.
  • When the copy node button is pressed.
  • After deleting a map, currently the browser is only redirected to the start page. Would be nice to see on the start page (so after redirect) "successfully deleted map"
  • I would also propose to change the current notification for the duplicate workflow: Show the message on the new map, not on the old one. Instead of the timeout, redirect and use a query parameter to show the message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants