-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add toasts where sensible #294
Add toasts where sensible #294
Conversation
...apper-frontend/src/app/modules/application/components/dialog-about/dialog-about.component.ts
Outdated
Show resolved
Hide resolved
...apper-frontend/src/app/modules/application/components/dialog-share/dialog-share.component.ts
Outdated
Show resolved
Hide resolved
This is really helpful, I really like these messages where it was unclear before what really happened 😂 👍 |
Latest commit fixes #297 |
fyi there is still a open file conflict I think |
Merged in latest main now, resolved it hopefully. |
Looks like adding the DialogService to the individual dialogs causes Chrome Headless to crash during tests for some reason - works in practice though. |
closes #288