Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support of one or more of choice clauses to EBNF parser: #161

Merged
merged 1 commit into from Feb 22, 2020

Conversation

jlittorin
Copy link
Contributor

[A | B | C]+

Resolves #160

@b3b00
Copy link
Owner

b3b00 commented Feb 22, 2020

Great job @jlittorin !
Nevertheless when running unit tests on my computer (Linux mint 19.1, dotnet sdk 3.0.1) I get following output in console :

Outil en ligne de commande d'exécution de tests Microsoft (R), version 16.3.0
Copyright (c) Microsoft Corporation. Tous droits réservés.

Démarrage de l'exécution de tests, patientez...

Au total, 1 fichiers de test ont correspondu au modèle spécifié.
ERROR : Unable to cast object of type 'System.Double' to type 'System.Int32'. calling primary_value =>  OperandInt
ERROR : Parameter count mismatch. calling operand =>  OperandValue
ERROR : Unable to cast object of type 'System.Double' to type 'System.Int32'. calling primary_value =>  OperandInt
ERROR : Parameter count mismatch. calling operand =>  OperandValue
ERROR : Parameter count mismatch. calling expr_10_PLUS_MINUS =>  BinaryTermExpression
1
1
2

Do you also have those ERROR messages. I do not have them when running tests on my repo (branch dev).
Could you check please ?

I can see it on appveyor ubuntu build so it surely is a linux dotnet issue.

thanks anyway.

@b3b00 b3b00 merged commit b57eee5 into b3b00:dev Feb 22, 2020
@jlittorin
Copy link
Contributor Author

The test runner in visual studio doesn't show this output, I guess I relied on that and all tests passing before I created the PR. The "parameter count mismatch" does look like something I could have caused though. I'll look into it.

@jlittorin
Copy link
Contributor Author

These problems were unrelated to my PR, they appeared in commit 137b304. Putting up a fix in a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for "one or more" of choice clauses
2 participants