qodana cleaning #803

1236 new problems found by Qodana for .NET

Qodana for .NET

1236 new problems were found

Inspection name	Severity	Problems
`Redundant type arguments of method`	🔶 Warning	111
`Assignment is not used`	🔶 Warning	42
`Namespace does not correspond to file location`	🔶 Warning	33
`Unused local variable`	🔶 Warning	33
`Expression is always 'true' or always 'false'`	🔶 Warning	15
`Possible 'System.NullReferenceException'`	🔶 Warning	14
`Auto-property accessor is never used (non-private accessibility)`	🔶 Warning	14
`Redundant member initializer`	🔶 Warning	13
`Virtual member call in constructor`	🔶 Warning	9
`Invalid XML documentation comment`	🔶 Warning	7
`Redundant using directive`	🔶 Warning	7
`Possible 'null' assignment to non-nullable entity`	🔶 Warning	5
`Non-readonly type member referenced in 'GetHashCode()'`	🔶 Warning	5
`Redundant 'object.ToString()' call`	🔶 Warning	5
`Unused parameter (private accessibility)`	🔶 Warning	4
`Collection content is never queried (private accessibility)`	🔶 Warning	3
`Unused type parameter`	🔶 Warning	3
`Co-variant array conversion`	🔶 Warning	2
`Conditional access qualifier expression is known to be null or not null`	🔶 Warning	2
`Member initialized value ignored`	🔶 Warning	2
`Possible multiple enumeration`	🔶 Warning	2
`Redundant cast`	🔶 Warning	2
`Dictionary lookup can be simplified with 'TryAdd'`	🔶 Warning	1
`Empty constructor`	🔶 Warning	1
`Expression is always 'null'`	🔶 Warning	1
`Local variable hides member`	🔶 Warning	1
`Non-accessed local variable`	🔶 Warning	1
`Mismatch of optional parameter value in overridden method`	🔶 Warning	1
`Redundant argument with default value`	🔶 Warning	1
`Redundant explicit type in array creation`	🔶 Warning	1
`Redundant control flow jump statement`	🔶 Warning	1
`Redundant lambda expression parameter type specification`	🔶 Warning	1
`Useless arithmetical operation`	🔶 Warning	1
`Type member is never used (non-private accessibility)`	◽️ Notice	112
`Member can be made private (non-private accessibility)`	◽️ Notice	104
`Use preferred 'var' style (for built-in types)`	◽️ Notice	90
`Invert 'if' statement to reduce nesting`	◽️ Notice	87
`Auto-property can be made get-only (non-private accessibility)`	◽️ Notice	58
`Use object or collection initializer when possible`	◽️ Notice	43
`Unused parameter (non-private accessibility)`	◽️ Notice	34
`Use preferred 'var' style (elsewhere)`	◽️ Notice	25
`Redundant 'else' keyword`	◽️ Notice	21
`Use preferred 'var' style (when type is simple)`	◽️ Notice	21
`Use preferred style of default value expression when type is not evident`	◽️ Notice	19
`Type is never used (non-private accessibility)`	◽️ Notice	19
`'if-return' statement can be rewritten as 'return' statement`	◽️ Notice	17
`Member can be made protected (non-private accessibility)`	◽️ Notice	15
`'if' statement can be rewritten as '?:' expression`	◽️ Notice	14
`Member can be made static (shared) (private accessibility)`	◽️ Notice	14
`Method return value is never used (non-private accessibility)`	◽️ Notice	14
`Convert delegate variable into local function`	◽️ Notice	13
`Field can be made readonly (non-private accessibility)`	◽️ Notice	11
`Part of foreach loop can be converted into LINQ-expression but another 'GetEnumerator' method will be used`	◽️ Notice	9
`Inline 'out' variable declaration`	◽️ Notice	8
`Parameter can be declared with the base type`	◽️ Notice	8
`Add/remove 'this.' qualifier`	◽️ Notice	7
`Class is never instantiated (non-private accessibility)`	◽️ Notice	7
`Local variable has too wide declaration scope`	◽️ Notice	7
`Type member is never accessed via base type (non-private accessibility)`	◽️ Notice	7
`Field can be made readonly (private accessibility)`	◽️ Notice	6
`Foreach loop can be converted into LINQ-expression but another 'GetEnumerator' method will be used`	◽️ Notice	6
`Convert constructor into member initializers`	◽️ Notice	5
`Inline temporary variable`	◽️ Notice	5
`Parameter type can be IEnumerable<T> (private accessibility)`	◽️ Notice	5
`Some values of the enum are not processed inside 'switch' statement and are handled via default section`	◽️ Notice	5
`Virtual (overridable) member is never overridden (non-private accessibility)`	◽️ Notice	5
`Convert 'if' statement into 'switch'`	◽️ Notice	4
`Non-accessed field (non-private accessibility)`	◽️ Notice	4
`Redundant empty argument list on object creation expression`	◽️ Notice	4
`Class with virtual (overridable) members never inherited (non-private accessibility)`	◽️ Notice	3
`Convert local variable or field into constant (private accessibility)`	◽️ Notice	3
`Merge conditional ?: expression into conditional access`	◽️ Notice	3
`Parameter type can be IEnumerable<T> (non-private accessibility)`	◽️ Notice	3
`Tail recursive call can be replaced with loop`	◽️ Notice	3
`Remove redundant parentheses`	◽️ Notice	2
`Auto-property can be made get-only (private accessibility)`	◽️ Notice	2
`Incorrect indent (around statement braces)`	◽️ Notice	2
`Convert lambda expression into method group`	◽️ Notice	2
`For-loop can be converted into foreach-loop`	◽️ Notice	2
`Loop can be converted into LINQ-expression`	◽️ Notice	2
`Member can be made static (shared) (non-private accessibility)`	◽️ Notice	2
`Redundant [AttributeUsage] attribute property assignment`	◽️ Notice	2
`Redundant explicit array creation in argument of 'params' parameter`	◽️ Notice	2
`Redundant lambda signature parentheses`	◽️ Notice	2
`Return type can be IEnumerable<T> (non-private accessibility)`	◽️ Notice	2
`Simplify LINQ expression (use 'All')`	◽️ Notice	2
`Replace if statement with null-propagating code`	◽️ Notice	2
`Literal length can be reduced by using verbatim string`	◽️ Notice	2
`Use preferred body style (convert into property, indexer, or event with preferred body style)`	◽️ Notice	1
`Use preferred style for trailing comma before new line in multiline lists`	◽️ Notice	1
`Replace built-in type reference with a CLR type name or a keyword`	◽️ Notice	1
`Use compound assignment`	◽️ Notice	1
`Convert into lambda expression`	◽️ Notice	1
`Introduce optional parameters (non-private accessibility)`	◽️ Notice	1
`Join local variable declaration and assignment`	◽️ Notice	1
`Merge sequential checks into single conditional access check`	◽️ Notice	1
`Redundant string interpolation`	◽️ Notice	1
`Replace auto-property with computed property`	◽️ Notice	1
`Replace with single call to Any(..)`	◽️ Notice	1
`Some values of the enum are not processed inside 'switch' statement`	◽️ Notice	1
`Unassigned field (non-private accessibility)`	◽️ Notice	1
`Use collection's count property`	◽️ Notice	1
`Use deconstruction`	◽️ Notice	1
`Use string interpolation expression`	◽️ Notice	1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Or via our issue tracker: https://jb.gg/qodana-issue
Or share your feedback: https://jb.gg/qodana-discussions

This result was published with Qodana GitHub Action

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

qodana cleaning #803

Qodana for .NET

qodana cleaning #803

Jobs

Run details

1236 new problems found by Qodana for .NET

Qodana for .NET

Details

Annotations

github-actions / Qodana for .NET

github-actions / Qodana for .NET

github-actions / Qodana for .NET

github-actions / Qodana for .NET

github-actions / Qodana for .NET

github-actions / Qodana for .NET

github-actions / Qodana for .NET

github-actions / Qodana for .NET

github-actions / Qodana for .NET

github-actions / Qodana for .NET

github-actions / Qodana for .NET

github-actions / Qodana for .NET

github-actions / Qodana for .NET

github-actions / Qodana for .NET

github-actions / Qodana for .NET

github-actions / Qodana for .NET

github-actions / Qodana for .NET

github-actions / Qodana for .NET

github-actions / Qodana for .NET

github-actions / Qodana for .NET

github-actions / Qodana for .NET

github-actions / Qodana for .NET

github-actions / Qodana for .NET

github-actions / Qodana for .NET

github-actions / Qodana for .NET

Re-running jobs...