Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README image are no longer displayed in Atom settings view #50

Closed
ftm opened this issue Sep 14, 2017 · 2 comments
Closed

README image are no longer displayed in Atom settings view #50

ftm opened this issue Sep 14, 2017 · 2 comments

Comments

@ftm
Copy link
Contributor

ftm commented Sep 14, 2017

In Atom the images in the README are not displayed as the relative URLs (which might have been my fault 😄) are not resolved correctly.

relative url before

This is an issue with the settings-view package, part of Atom itself. I have already created an issue and a pull request to deal with this. I'm just putting this here in case somebody else spots it and wants to do something about it.

@b3by
Copy link
Owner

b3by commented Sep 15, 2017

Ok, thank you for that. I didn't notice the bug in the Settings view, but that's quite annoying (although, I have the feeling that more people look at the readme online, rather than in there).
I just hope the issue will be closed soon enough, otherwise the bug could be closed with a rollback of the urls to the previous version - I'd rather avoid that.

Thanks!

@ftm
Copy link
Contributor Author

ftm commented Oct 26, 2017

My PR on settings-view got merged so I think this should be all good once the next version of Atom gets pushed out

@ftm ftm closed this as completed Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants