Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imwheel #200

Merged
merged 3 commits into from
Dec 4, 2022
Merged

Add imwheel #200

merged 3 commits into from
Dec 4, 2022

Conversation

jackbrower
Copy link
Contributor

No description provided.

@b3nj5m1n
Copy link
Owner

b3nj5m1n commented Dec 2, 2022

Hi, first of all, thanks for your contribution!

I'm a bit confused by your description, since only /etc/X11/imwheel/imwheelrc and $HOME/.imwheelrc are considered, symlinking to $XDG_CONFIG_HOME/imwheelrc isn't going to do anything.

I'll suggest some changes based on what I gathered from the manpage.

programs/imwheel.json Outdated Show resolved Hide resolved
@jackbrower
Copy link
Contributor Author

Hi, first of all, thanks for your contribution!

I'm a bit confused by your description, since only /etc/X11/imwheel/imwheelrc and $HOME/.imwheelrc are considered, symlinking to $XDG_CONFIG_HOME/imwheelrc isn't going to do anything.

I'll suggest some changes based on what I gathered from the manpage.

Hi, I agree what I wrote could have been phrased a little better. The intent was to show a workaround where you could write a config file in your home and then link it to the global config (which I found may differ based on distro or version). I tested this locally and it worked as intended.

@b3nj5m1n
Copy link
Owner

b3nj5m1n commented Dec 4, 2022

Usually, symlinking from a local to global config file is not something you want to do, and I don't think we should suggest it. I'll apply my suggestion and merge this for now, if there's any specific reason you'd want to do it the way you suggested, feel free to open an issue.

@b3nj5m1n b3nj5m1n merged commit 2f22b6e into b3nj5m1n:main Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants