Add flake.nix #226
Add flake.nix #226
Conversation
|
Hi! First of all, thank you for this! I'm currently in the process of nix'ifying a lot of my personal projects, so great timing as well. I have to admit that I'm a little confused about where this package definition is supposed to go, since it's already a package in the official nixpkgs repo. It doesn't seem like a good idea to maintain both, but it also seems like a good idea to maintain it as part of a flake in the project's repository. I guess my question is what the current best practice is regarding this, would the nixpkgs definition be changed to use this flake, should we change the definition of this flake to use the nixpkgs definition and overwrite the I'd also like to add a dev shell, but I can do that myself after this PR is merged. |
flake.nix
Outdated
| install -Dm755 xdg-ninja.sh "$out/share/xdg-ninja/xdg-ninja.sh" | ||
| install -Dm644 programs/* -t "$out/share/xdg-ninja/programs" | ||
| mkdir -p "$out/bin" | ||
| ln -s "$out/share/xdg-ninja/xdg-ninja.sh" "$out/bin/xdg-ninja" |
There was a problem hiding this comment.
Why not move it to $out/bin in the first place?
There was a problem hiding this comment.
install handles file permissions (setting the executable flag) at the same time.
|
Oh, I did not see the official package 😆 I'm not quite sure what the etiquette there is. Maybe opening something on the Nix Discourse would be a good idea? |
|
Since I'm a little busy at the moment, for now I just did what seemed the most sensible to me. (Use the derivation I hope I'm using that term correctly from the official nixpkgs repo and overwrite the Thank you again for the contribution! |
This adds support for Nix flakes.