Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fzf #231

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Add fzf #231

merged 1 commit into from
Mar 29, 2023

Conversation

mxmlnkn
Copy link
Contributor

@mxmlnkn mxmlnkn commented Mar 28, 2023

This also affects ~/.fzf.bash and possibly ~/.fzf.zsh but those are removed by the uninstall script. I'm unsure whether to list both files separately in the json file.

@b3nj5m1n
Copy link
Owner

b3nj5m1n commented Mar 29, 2023

This also affects ~/.fzf.bash and possibly ~/.fzf.zsh

In theory, we should add them. (Although there are probably even more for other shells)

Is XDG respected by default in newer versions? Since it seems like the minimum version you specified has been out for quite a while, I don't think it's necessary to add all individual files if new users will never see them.

If the default behavior of fzf is still to create these files in the home directory, though, I think we should add all of the files it might create.

I'll go ahead and merge this now, I might have time to look into this myself today.

Edit: Seems like it does indeed still use the home directory by default. Added the two files in 05eb43e.

@b3nj5m1n b3nj5m1n merged commit 4ee4799 into b3nj5m1n:main Mar 29, 2023
@mxmlnkn
Copy link
Contributor Author

mxmlnkn commented Mar 29, 2023

Is XDG respected by default in newer versions?

When installing from source, no. The --xdg option is still necessary. I don't know how it behaves when installing it via the package manager. I know that in that case there are some manual instructions for installing the bash/zsh bindings. I assume that those also install .fzf.bash but not the .fzf folder, which contains the git repository and the compiled binary among others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants