Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the full list of programs from issue #80. #82

Merged
merged 6 commits into from
Jun 6, 2022
Merged

add the full list of programs from issue #80. #82

merged 6 commits into from
Jun 6, 2022

Conversation

amtoine
Copy link
Contributor

@amtoine amtoine commented Jun 6, 2022

Here is the full list of programs discussed in issue #80.

Some of the programs are unknown and/or unclear about what we can do with their hidden files, these might lead to new issues and PRs in the future.

Copy link
Owner

@b3nj5m1n b3nj5m1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that was quick, thank you so much!

There were a few problems with the markdown, (not closing italics formatting) hopefully I caught all of those in my review.

I left a couple of comments that I think we should address before I merge this, I should be able to take a look at a couple of them on my own.

{
"files": [
{
"help": "Currently unsupported. Won't fix.\n",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afaik, there are shells and window managers that don't need this file and won't create it, perhaps we should add a note about that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true that some shells and WMs do not use that 🤔
Would you like to start a list of shells and WMs that do not need ~/.profile? Maybe that's for another time though!

For now, I add a note in that program, to mention that, depending on the shell and the WM running, ~/.profile should be removed without problem 👌

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be addressed in 4193a7e

Comment on lines 1 to 15
{
"files": [
{
"help": "Currently unsupported. No information found.\n",
"movable": false,
"path": "$HOME/.pulse"
},
{
"help": "Currently unsupported. No information found.\n",
"movable": false,
"path": "$HOME/.pulse-cookie"
}
],
"name": "pulseaudio"
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulseaudio should actually be supported natively, I use pulse and don't have these files, and according to this issue it's supported since version 4.0.

Also relevant is this commit, as well as this one. From the descriptions:

core-util: move configuration home directory from ~/,pulse to ~/.config/pulse to follow XDG basedir spec

In order to follow XDG basedir, read the cookie file from
~/.config/pulse/cookie if possible, but fall back to the old file.
if it doesn't exist.

It will use ~/.pulse if it exists. Could you try moving these files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okey that's cool! I have to admit I am not super confident in my knowledge in audio drivers 😆
I think I migtht be using pulseaudio, but probably a mixture with alsa as I can control my sound with both alsamixer and pulsemixer.
I know, it's something I plan to learn about when having a problem some day or when rebuilding Arch 👀

I add that to the program as removing both ~/.pulse and ~/.pulse-cookie does not appear to do much harm 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be addressed in 7ccb925

Comment on lines 7 to 11
},
{
"help": "Supported since _8.0.0_.\n\nYou can move the file to _XDG_CONFIG_HOME/ipython.\n",
"movable": true,
"path": "$HOME/.ipython"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ipython is a standalone program, so it should get its own configuration file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking into it, looks like one can define the IPYTHONDIR environment variable to change the config file 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, sorry, I did not understand, I put them in separate files 👌

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be addressed in 813f12

Comment on lines 1 to 20
{
"files": [
{
"help": "Since 7.3.1178 vim will search for ~/.vim/vimrc if ~/.vimrc is not found.\n\n\"$XDG_CONFIG_HOME\"/vim/vimrc\n```vim\nset runtimepath^=$XDG_CONFIG_HOME/vim\nset runtimepath+=$XDG_DATA_HOME/vim\nset runtimepath+=$XDG_CONFIG_HOME/vim/after\n\nset packpath^=$XDG_DATA_HOME/vim,$XDG_CONFIG_HOME/vim\nset packpath+=$XDG_CONFIG_HOME/vim/after,$XDG_DATA_HOME/vim/after\n\nlet g:netrw_home = $XDG_DATA_HOME.\"/vim\"\ncall mkdir($XDG_DATA_HOME.\"/vim/spell\", 'p')\n\nset backupdir=$XDG_STATE_HOME/vim/backup | call mkdir(&backupdir, 'p')\nset directory=$XDG_STATE_HOME/vim/swap | call mkdir(&directory, 'p')\nset undodir=$XDG_STATE_HOME/vim/undo | call mkdir(&undodir, 'p')\nset viewdir=$XDG_STATE_HOME/vim/view | call mkdir(&viewdir, 'p')\n\nif !has('nvim') | set viminfofile=$XDG_STATE_HOME/vim/viminfo | endif\n```\n\n~/.profile\n```\nexport GVIMINIT='let $MYGVIMRC=\"$XDG_CONFIG_HOME/vim/gvimrc\" | source $MYGVIMRC'\nexport VIMINIT='let $MYVIMRC=\"$XDG_CONFIG_HOME/vim/vimrc\" | source $MYVIMRC'\n```\n[G]VIMINIT environment variable will also affect Neovim. If separate configs for Vim and Neovim are desired then the following will be a better choice:\n\n```\nexport GVIMINIT='let $MYGVIMRC = !has(\"nvim\") ? \"$XDG_CONFIG_HOME/vim/gvimrc\" : \"$XDG_CONFIG_HOME/nvim/init.gvim\" | so $MYGVIMRC'\nexport VIMINIT='let $MYVIMRC = !has(\"nvim\") ? \"$XDG_CONFIG_HOME/vim/vimrc\" : \"$XDG_CONFIG_HOME/nvim/init.vim\" | so $MYVIMRC'\n```\n\nAdditional information:\nhttps://blog.joren.ga/vim-xdg\nhttps://tlvince.com/vim-respect-xdg\n",
"movable": true,
"path": "$HOME/.vimrc"
},
{
"help": "Since 7.3.1178 vim will search for ~/.vim/vimrc if ~/.vimrc is not found.\n\n\"$XDG_CONFIG_HOME\"/vim/vimrc\n```vim\nset runtimepath^=$XDG_CONFIG_HOME/vim\nset runtimepath+=$XDG_DATA_HOME/vim\nset runtimepath+=$XDG_CONFIG_HOME/vim/after\n\nset packpath^=$XDG_DATA_HOME/vim,$XDG_CONFIG_HOME/vim\nset packpath+=$XDG_CONFIG_HOME/vim/after,$XDG_DATA_HOME/vim/after\n\nlet g:netrw_home = $XDG_DATA_HOME.\"/vim\"\ncall mkdir($XDG_DATA_HOME.\"/vim/spell\", 'p')\n\nset backupdir=$XDG_STATE_HOME/vim/backup | call mkdir(&backupdir, 'p')\nset directory=$XDG_STATE_HOME/vim/swap | call mkdir(&directory, 'p')\nset undodir=$XDG_STATE_HOME/vim/undo | call mkdir(&undodir, 'p')\nset viewdir=$XDG_STATE_HOME/vim/view | call mkdir(&viewdir, 'p')\n\nif !has('nvim') | set viminfofile=$XDG_STATE_HOME/vim/viminfo | endif\n```\n\n~/.profile\n```vim\nexport GVIMINIT='let $MYGVIMRC=\"$XDG_CONFIG_HOME/vim/gvimrc\" | source $MYGVIMRC'\nexport VIMINIT='let $MYVIMRC=\"$XDG_CONFIG_HOME/vim/vimrc\" | source $MYVIMRC'\n```\n[G]VIMINIT environment variable will also affect Neovim. If separate configs for Vim and Neovim are desired then the following will be a better choice:\n\n```\nexport GVIMINIT='let $MYGVIMRC = !has(\"nvim\") ? \"$XDG_CONFIG_HOME/vim/gvimrc\" : \"$XDG_CONFIG_HOME/nvim/init.gvim\" | so $MYGVIMRC'\nexport VIMINIT='let $MYVIMRC = !has(\"nvim\") ? \"$XDG_CONFIG_HOME/vim/vimrc\" : \"$XDG_CONFIG_HOME/nvim/init.vim\" | so $MYVIMRC'\n```\n\nAdditional information:\nhttps://blog.joren.ga/vim-xdg\nhttps://tlvince.com/vim-respect-xdg\n",
"movable": true,
"path": "$HOME/.viminfo"
},
{
"help": "Since 7.3.1178 vim will search for ~/.vim/vimrc if ~/.vimrc is not found.\n\n\"$XDG_CONFIG_HOME\"/vim/vimrc\n```vim\nset runtimepath^=$XDG_CONFIG_HOME/vim\nset runtimepath+=$XDG_DATA_HOME/vim\nset runtimepath+=$XDG_CONFIG_HOME/vim/after\n\nset packpath^=$XDG_DATA_HOME/vim,$XDG_CONFIG_HOME/vim\nset packpath+=$XDG_CONFIG_HOME/vim/after,$XDG_DATA_HOME/vim/after\n\nlet g:netrw_home = $XDG_DATA_HOME.\"/vim\"\ncall mkdir($XDG_DATA_HOME.\"/vim/spell\", 'p')\n\nset backupdir=$XDG_STATE_HOME/vim/backup | call mkdir(&backupdir, 'p')\nset directory=$XDG_STATE_HOME/vim/swap | call mkdir(&directory, 'p')\nset undodir=$XDG_STATE_HOME/vim/undo | call mkdir(&undodir, 'p')\nset viewdir=$XDG_STATE_HOME/vim/view | call mkdir(&viewdir, 'p')\n\nif !has('nvim') | set viminfofile=$XDG_STATE_HOME/vim/viminfo | endif\n```\n\n~/.profile\n```vim\nexport GVIMINIT='let $MYGVIMRC=\"$XDG_CONFIG_HOME/vim/gvimrc\" | source $MYGVIMRC'\nexport VIMINIT='let $MYVIMRC=\"$XDG_CONFIG_HOME/vim/vimrc\" | source $MYVIMRC'\n```\n[G]VIMINIT environment variable will also affect Neovim. If separate configs for Vim and Neovim are desired then the following will be a better choice:\n\n```\nexport GVIMINIT='let $MYGVIMRC = !has(\"nvim\") ? \"$XDG_CONFIG_HOME/vim/gvimrc\" : \"$XDG_CONFIG_HOME/nvim/init.gvim\" | so $MYGVIMRC'\nexport VIMINIT='let $MYVIMRC = !has(\"nvim\") ? \"$XDG_CONFIG_HOME/vim/vimrc\" : \"$XDG_CONFIG_HOME/nvim/init.vim\" | so $MYVIMRC'\n```\n\nAdditional information:\nhttps://blog.joren.ga/vim-xdg\nhttps://tlvince.com/vim-respect-xdg\n",
"movable": true,
"path": "$HOME/.vim"
}
],
"name": "vim"
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't repeat all this for every file. If there's no way to properly split this up between the files, we should output it once for one of the files and then add something like "See help for .vimrc" to the other ones, otherwise I think the output might get too cluttered.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very sensible to me, was not sure about the way to simplify that.

I put everything in $HOME/.vimrc as it looks the most iconic of the three to me 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be addressed in d2fbe9b

programs/emacs.json Outdated Show resolved Hide resolved
programs/themes.json Outdated Show resolved Hide resolved
programs/trash.json Outdated Show resolved Hide resolved
programs/virtualbox.json Outdated Show resolved Hide resolved
programs/when.json Outdated Show resolved Hide resolved
programs/xonsh.json Outdated Show resolved Hide resolved
@amtoine
Copy link
Contributor Author

amtoine commented Jun 6, 2022

I think the _ _ have been swallowed by emacs because of the _s inside XDG_*_HOME, your fixes look fine 👌

Copy link
Owner

@b3nj5m1n b3nj5m1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Again, thanks a lot for your work on this!

@b3nj5m1n b3nj5m1n merged commit 6efc7cf into b3nj5m1n:main Jun 6, 2022
@amtoine
Copy link
Contributor Author

amtoine commented Jun 6, 2022

Looks good to me.

cool 😋

Again, thanks a lot for your work on this!

again, you're welcome 😊

@amtoine amtoine deleted the 80-full-list-of-missing-programs branch June 8, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants