Build: Fix issues with spaces in path #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. I will take a look at this in the next few days. |
b4winckler
added a commit
that referenced
this pull request
Aug 26, 2011
Handle spaces in output directories
ivanoats
pushed a commit
to ivanoats/macvim
that referenced
this pull request
Jan 13, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build would fail during the Make Document Icons phase with spaces present in the path to the source. I've quoted the relevant variables in both this phase's shellscript and the icons Makefile, and subsequently succeeded in building a working MacVim