Merge 532f3b9 into 64216a8

.github/workflows/shellcheck.yml

@@ -0,0 +1,14 @@
+name: Shellcheck
+
+on: [push,pull_request]
+
+jobs:
+  shellcheck:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: Run Shellcheck
+        uses: reviewdog/action-shellcheck@v1
+        with:
+          github_token: ${{ secrets.GITHUB_TOKEN }}
+          level: warning

scripts/test-utils.sh

@@ -7,8 +7,8 @@ DUMP_FILE=logs/example-$(date --iso).fuel
 
 function executeWithArguments() {
 	rm -rf stdout stderr logs
-	LAST_ARGUMENTS=$@
-	"$PHARO" "$IMAGE" example $@ --quit > out 2> err || true
+	LAST_ARGUMENTS=$*
+	"$PHARO" "$IMAGE" example "$@" --quit > out 2> err || true
 	[ -f stdout ] && mv stdout out || touch out
 	[ -f stderr ] && mv stderr err || touch err
 }
@@ -18,7 +18,7 @@ function assertOutputIncludesMessage() {
 	local level=$2
 	local message=$3
 
-	if [ $(grep -c "^\[[0-9T.:+-]*\] \[$level\] $message" "$output") -eq 0 ]; then
+	if [ "$(grep -c "^\[[0-9T.:+-]*\] \[$level\] $message" "$output")" -eq 0 ]; then
 		echo "Expected std$1 to have: [$level] '$message' when invoked with $LAST_ARGUMENTS"
 		exit 1
 	fi

scripts/test.sh

@@ -1,6 +1,7 @@
 #!/usr/bin/env bash
 set -euo pipefail
 
+# shellcheck source=test-utils.sh
 source test-utils.sh
 
 executeWithArguments --add=5