Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --dry-run option to launchpad start #69

Merged
merged 10 commits into from
Apr 19, 2024
Merged

Conversation

gcotelli
Copy link
Member

  • Add --dry-run option to launchpad start
  • Improve LaunchpadTest to make it easier to test the configuration of an application
  • Improve LaunchpadCommandLine handler so it's easier to activate it by hand

Based on #64 made by @macta

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.79%. Comparing base (5bab6ee) to head (ecdc1b4).

Additional details and impacted files
@@                 Coverage Diff                 @@
##           release-candidate      #69    +/-   ##
===================================================
  Coverage              99.78%   99.79%            
===================================================
  Files                     58       62     +4     
  Lines                   3751     3870   +119     
===================================================
+ Hits                    3743     3862   +119     
  Misses                     8        8            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gcotelli gcotelli marked this pull request as ready for review April 18, 2024 20:32
Copy link
Contributor

@macta macta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a bit hard to review as there are lots of format changes from symbol to string - but I like the dry-run tests, and I can see there is an option to get at config symbolically.

.docker/gs64/docker-tests.sh Show resolved Hide resolved
docs/reference/CLI.md Outdated Show resolved Hide resolved
@gcotelli gcotelli merged commit d0dc79f into release-candidate Apr 19, 2024
68 checks passed
@gcotelli gcotelli deleted the dry_run_option branch April 19, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants