Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null config for testing #73

Open
wants to merge 2 commits into
base: release-candidate
Choose a base branch
from

Conversation

macta
Copy link
Contributor

@macta macta commented May 7, 2024

Simple proposal to slightly extend the NullConfigurationProvider with at:put: functionality so its easy to write tests for launchpad parameter conversion. Also has an example web server demonstrating a test.

While I could subclass NullConfigurationProvider in my own code, I'm hoping this change is non-controversial and hopefully shows others how they could easily write a similar test.

Understand if you prefer not to include this (and I can make my own subclass) but thought it might be interesting enough to include.

p.s. sorry for the extra changes - the change from P11 to P12 for category format type is annoying.

Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 76.76056% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 98.97%. Comparing base (3611d90) to head (44cbfc7).

Files Patch % Lines
...hpad-Examples/LaunchpadZnHelloApplication.class.st 52.17% 33 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release-candidate      #73      +/-   ##
=====================================================
- Coverage              99.79%   98.97%   -0.82%     
=====================================================
  Files                     62       64       +2     
  Lines                   3870     4011     +141     
=====================================================
+ Hits                    3862     3970     +108     
- Misses                     8       41      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant