Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use API Client instead of a plain ZnClient #50

Conversation

gcotelli
Copy link
Member

It provides caching and connection pooling

Fixes #47

It provides caching and connection pooling
@gcotelli gcotelli self-assigned this Nov 26, 2021
@gcotelli gcotelli added this to the v3.0.0 milestone Nov 26, 2021
@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #50 (5ae4ef8) into release-candidate (5d649ab) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-candidate      #50   +/-   ##
==================================================
  Coverage              99.62%   99.62%           
==================================================
  Files                     53       53           
  Lines                   2960     2960           
==================================================
  Hits                    2949     2949           
  Misses                    11       11           
Impacted Files Coverage Δ
...uminalServiceDiscoveryExampleLauncherTest.class.st 100.00% <100.00%> (ø)
...ry/ConsulAgentHttpAPIBasedDiscoveryClient.class.st 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d649ab...5ae4ef8. Read the comment docs.

@gcotelli gcotelli merged commit 1740576 into release-candidate Nov 26, 2021
@gcotelli gcotelli deleted the 47-Add-a-connection-pool-to-ConsulAgentHttpAPIBasedDiscoveryClient branch November 26, 2021 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a connection pool to ConsulAgentHttpAPIBasedDiscoveryClient
2 participants