Heartbeat #11
Heartbeat #11
Conversation
|
That geom.txt file just identifies neighbors. It does look like things were missing so updating it means some old shows are going to potentially work better. I didn't go through the changes in detail. Test the other shows that use the vertex_neighbors and edge_neighbors functions. As for OSC - AAAAACCCCKKKK!!!!!! Use controls_model. A show should NEVER touch OSC directly. Sorry that apparently wasn't written in bold letters somewhere. Shows don't know about OSC or web or midi or keyboard or anything. They know about the controls exposed by control_model and the user has different paths for modifying those. I didn't study heartbeat in detail, but it looks to me like you might be able to handle the timing and looping more easily if you just extended LoopingShow instead handling those details yourself. LoopingShow properly handles the global speed modifier. If you don't inherit from it, thats something you would have to handle yourself. |
|
Oh - and thank you for writing a show ;) |
|
@mdlima re: this show, be sure to make sure it'll merge against the branch -- https://github.com/baaahs/lights/tree/baaahs-playa-2017 there's an issue with master and i've devote a bit of time to fixing it and have run out of time @mdlima i'm about 32 hours from heading out, so if you've got additional changes, no prob, just bring them on a usb stick or your laptop and we can push them / make them to the server |
Hey, here's the PR for my first show: Heartbeat.
I had to redo the geom.txt file to map correctly all the edge and vertex neighbors. It's still not complete (the face is missing), but I wanted to check with you if this won't impact other shows in a negative way.
As for the show, I still want to add OSC control (having a hard time setting it up locally), but I wanted to get feedback from you as soon as possible.
Please check it out and let me know if I'm in the right direction.
Cheers