Validate panel grid arrangement in layout editor #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xian
commented
Feb 20, 2021
|
|
||
| object LayoutValidatorSpec : Spek({ | ||
| describe<LayoutValidator> { | ||
| val layoutValidator by value { LayoutValidator() } |
There was a problem hiding this comment.
This by value thing creates a new instance for every spec — for each it block.
xian
commented
Feb 20, 2021
| object LayoutValidatorSpec : Spek({ | ||
| describe<LayoutValidator> { | ||
| val layoutValidator by value { LayoutValidator() } | ||
| val tab by value<Tab> { toBeSpecified() } |
There was a problem hiding this comment.
You can also useoverride to change the value in nested contexts, see below.
xian
commented
Feb 20, 2021
| val invalidRegions by value { layoutValidator.findInvalidRegions(tab) } | ||
|
|
||
| context("when all regions are single cells") { | ||
| override(tab) { tab(3, 3, "ABC DEF GHI") } |
There was a problem hiding this comment.
This makes it behave as though line 14 had this value the whole time, within this context.
xian
commented
Feb 20, 2021
| } | ||
| }) | ||
|
|
||
| fun tab(columns: Int, rows: Int, areas: String): Tab { |
There was a problem hiding this comment.
Helper method to convert "aa bb" to a Tab with ["a", "a", "b", "b"].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-cell panels in the grid must follow CSS Grid rules: they must be rectangular and contiguous.
If the arrangement is invalid, show that there's an error, maybe indicate which panels are invalid, and refuse to apply the change.