EPIG implementation #270
EPIG implementation #270
Conversation
baal/active/heuristics/heuristics.py
Outdated
| """ | ||
| logprobs = torch.clone(probs) # [*N, Cl] | ||
| logprobs[probs > 0] = torch.log(probs[probs > 0]) # [*N, Cl] | ||
| return -torch.sum((probs * logprobs), dim=-1) # [*N,] |
There was a problem hiding this comment.
This can all be cut to return -torch.sum(torch.xlogy(probs, probs), dim=-1)
|
With @fbickfordsmith latest AISTAT paper link I think we should really more this PR forward. I refactored a bit and assuming the equations in EPIG are correct I think we can merge that pretty soon. Freddie, if your energy takes you there, could you review the code of EPIG? In particular the |
|
Great that you're moving this forward! Happy to support. I'm at ICLR this week so can't look at the code for a while, but I've added this to my to-do list. |
|
Nice work @Dref360 @reeshipaul! Looks good overall. I have some minor suggestions. Probably easiest if I push some changes for you to look at. What's the best way to do that? If @reeshipaul gives me push access to https://github.com/reeshipaul/baal then I could create a branch there. Open to alternatives too. |
|
In case @reeshipaul doesn't answer back, feel free to submit comments with suggestion. |
|
@fbickfordsmith this has been merged into baal-org:features/epig_release, please submit a PR against it with your changes. |
Summary:
Issue #259
Features:
Checklist:
tests/documentation_test.py).