Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Java time attempt 2 #1379

Closed
wants to merge 8 commits into from
Closed

Conversation

frenchy64
Copy link

@frenchy64 frenchy64 commented Sep 30, 2022

Second attempt at #1298. Corresponding PR dm3/clojure.java-time#93

Please answer the following questions and leave the below in as part of your PR.

@@ -458,6 +471,7 @@
java.util.zip.ZipFile
sun.misc.Signal
sun.misc.SignalHandler
sun.util.calendar.ZoneInfo
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems suspicious. What is the reason for inclusion?

Copy link
Author

@frenchy64 frenchy64 Oct 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I agree. Included it mainly to get tests passing and proceed without further distractions, no other reason. Was planning to have a second pass to cull unnecessary classes once the port is done.

@arichiardi
Copy link
Contributor

Hi there, can I help in any shape of form here (maybe rebasing?)

I had again the though cause I was about to roll my own conversion functions that clojure.java-time has already, if only I could add it to my babashka-compatible project.

@borkdude
Copy link
Collaborator

borkdude commented Jul 6, 2023

There is one comment about the sun class which wasn't addressed.

@borkdude
Copy link
Collaborator

I'm closing this as this PR looks a bit stale? Feel free to just provide smaller PRs that we can merge immediately. By now several java.time classes have been added, perhaps the PR isn't necessary anymore?

@borkdude borkdude closed this Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants