-
-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Java time attempt 2 #1379
Conversation
@@ -458,6 +471,7 @@ | |||
java.util.zip.ZipFile | |||
sun.misc.Signal | |||
sun.misc.SignalHandler | |||
sun.util.calendar.ZoneInfo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems suspicious. What is the reason for inclusion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I agree. Included it mainly to get tests passing and proceed without further distractions, no other reason. Was planning to have a second pass to cull unnecessary classes once the port is done.
Hi there, can I help in any shape of form here (maybe rebasing?) I had again the though cause I was about to roll my own conversion functions that |
There is one comment about the sun class which wasn't addressed. |
I'm closing this as this PR looks a bit stale? Feel free to just provide smaller PRs that we can merge immediately. By now several java.time classes have been added, perhaps the PR isn't necessary anymore? |
Second attempt at #1298. Corresponding PR dm3/clojure.java-time#93
Please answer the following questions and leave the below in as part of your PR.
I have read the developer documentation.
This PR corresponds to an issue with a clear problem statement.
This PR contains a test to prevent against future regressions
I have updated the CHANGELOG.md file with a description of the addressed issue.