with-temp-dir can raise a AccessDeniedException exception

[jlesquembre]

This code fails with an exception:

(fs/with-temp-dir [tmp-dir {:prefix "demo"}]
   (fs/create-dir (fs/path tmp-dir "my-dir")
                  {:posix-file-permissions "r-xr-xr-x"})
   (fs/create-file (fs/path tmp-dir "my-dir" "my-file")
                   {:posix-file-permissions "r--r--r--"}))

To delete a file, the parent directory must have the OWNER_WRITE permission.

IMO, with-temp-dir shouldn't fail in this case.

A possible solution could be to add a flag to delete-tree (:force??), to set the OWNER_WRITE permission in :pre-visit-dir, and then update with-temp-dir to invoke it with the flag set to true.

If it makes sense to you, I could open a PR.

[borkdude]

Is this an artificial example or a real-life-scenario example?

[jlesquembre]

It is a minimal example, the real world example is that I run maven in a temp dir to see what files are installed and generate a cache. For some reason, some directories are read-only.
In general, it applies to any tool you want to run in a temporary directory, for testing purposes. I could image the same issue if I want to write tests for Nix.

On those cases, you don't have control over the external tool.

But if that case doesn't make sense, or you don't what to support it, feel free to close this issue.

[borkdude]

I'm fine with receiving the PR. Please make the :force option without a question-mark, which is the style adopted for this library.