Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: Run clj-kondo --lint in CI #100

Closed
rads opened this issue Aug 13, 2022 · 1 comment · Fixed by #106
Closed

Dev: Run clj-kondo --lint in CI #100

rads opened this issue Aug 13, 2022 · 1 comment · Fixed by #106

Comments

@rads
Copy link
Collaborator

rads commented Aug 13, 2022

I noticed CI was passing in my PR despite having an unused require. Usually IntelliJ catches this for me (there's a plugin for clj-kondo integration) but for some reason Cursive is getting errors in this project and my usual editor linting is not working.

Do we want to block on clj-kondo --lint in GitHub Actions so we can catch these issues before merging to main?

@borkdude
Copy link
Contributor

Sounds good to me. I think the setup-clojure action also has clj-kondo.

@rads rads mentioned this issue Aug 14, 2022
2 tasks
@rads rads mentioned this issue Aug 16, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants