Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run clj-kondo --lint in CI #106

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Run clj-kondo --lint in CI #106

merged 1 commit into from
Aug 15, 2022

Conversation

rads
Copy link
Collaborator

@rads rads commented Aug 14, 2022

Please answer the following questions and leave the below in as part of your PR.

Overview

Resolves #100.

I split the workflow into separate files so the tests can still run even if the linter is failing.

@rads
Copy link
Collaborator Author

rads commented Aug 14, 2022

Example failure: rads@ea8eee1

image

@rads
Copy link
Collaborator Author

rads commented Aug 14, 2022

This may require some GitHub repo changes to make these checks required.

@borkdude borkdude merged commit e21bc88 into babashka:main Aug 15, 2022
@borkdude
Copy link
Contributor

@rads I invited you to this repo as maintainer so hopefully you can configure the build yourself. I still prefer going through PRs for code changes, but for trivial things like CI tweaks or documentation PRs, etc it's ok to bypass my review.

@rads
Copy link
Collaborator Author

rads commented Aug 15, 2022

@borkdude: Whoa! Thanks for trusting me with this. One thing, though, is that I don't think I have enough privileges to change the CI requirements. You may need to give me more access or just do the CI part yourself. Either way works for me.

Either way I'll keep in mind your statement about the documentation PRs. I'll probably err towards the safer side and get your review for everything until I get the hang of it.

@borkdude
Copy link
Contributor

I don't see how I can add status checks for linting, but I'm fine with keeping it as it is now since we'll notice that linting fails in a PR anyway, we don't have to mechanically block the PR I think.

Screenshot 2022-08-16 at 22 51 32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev: Run clj-kondo --lint in CI
2 participants