-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
neil dep add
: Prefer stable versions
#146
Comments
I don't agree on this one. There are some libraries like hiccup and clojure.data.xml which have been using alpha versions for years and everybody uses those. |
Fair enough. Personally I think it's bad practice to encourage the use of alpha versions as the default for all dependencies. If there's a library that everyone uses as an alpha, that should be the exception rather than the rule. It seems like the ideal behavior would be to install stable versions by default and allow for overrides for specific libraries where the alpha versions are preferred. I've been trying to use Feel free to close this or move to a discussion, whatever you prefer. |
@rads Yes, I think you're right, these deps should be the exception. As long as neil doesn't downgrade them to stable versions once you have set them to alpha, it should be good. Might also be good to check what other tools like antq do here? |
@rads Just FYI, I changed my mind on this and I agree that this should be addressed, as long as existing alpha versions aren't downgraded to stable versions (because that would be annoying for things like hiccup and clojure.data.xml). |
@borkdude: Thanks for letting me know! I apologize if any part of my previous comment came off as snarky. I just want to make sure I get my point across as concisely as possible but also acknowledge it's your decision so we don't have to waste time going back and forth on issues where we may disagree. |
Not at all, no problem |
Where do -SNAPSHOT versions fall in this? Currently, |
I see this is partially mentioned in #145 , but I think it should be considered for upgrade purposes as well. |
I'd say the behavior should be "never downgrade". Perhaps we can use version-clj to do the version comparisons: https://github.com/xsc/version-clj (and lazily load it for good startup time). |
I think installing a stable version is what most users want in the end.
Current behavior:
Expected behavior:
The text was updated successfully, but these errors were encountered: