Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neil dep upgrade still upgrades git dep #229

Closed
borkdude opened this issue Jul 1, 2024 · 8 comments
Closed

neil dep upgrade still upgrades git dep #229

borkdude opened this issue Jul 1, 2024 · 8 comments

Comments

@borkdude
Copy link
Contributor

borkdude commented Jul 1, 2024

Repro:

{:deps {io.github.nextjournal/markdown {:git/sha "6683c48dfdb23404a23057817b6ac3acf0310bca" :neil/pinned true}}}

Run neil dep upgrade and it upgrades the dep.

@borkdude
Copy link
Contributor Author

borkdude commented Jul 1, 2024

cc @teodorlu

@teodorlu
Copy link
Contributor

teodorlu commented Jul 1, 2024

I'll have a look.

teodorlu added a commit to teodorlu/neil that referenced this issue Jul 1, 2024
@teodorlu
Copy link
Contributor

teodorlu commented Jul 1, 2024

I failed to reproduce the error with this test: teodorlu@e756580 (I get all green tests, was expecting a red test).

I'll put some more effort into it later.

@borkdude
Copy link
Contributor Author

borkdude commented Jul 1, 2024 via email

@borkdude
Copy link
Contributor Author

borkdude commented Jul 1, 2024

Also :mvn/version dep is still upgrading, weirdly enough

@teodorlu
Copy link
Contributor

teodorlu commented Jul 1, 2024

Ok. Compiled script is in sync with source, right? (bb gen-script)

@borkdude
Copy link
Contributor Author

borkdude commented Jul 1, 2024

I've tested with the brew-installed script, but I'll re-test with the local script

@borkdude
Copy link
Contributor Author

borkdude commented Jul 1, 2024

Hmm, with the local script, it does work like expected. Seems like a release problem then...

@borkdude borkdude closed this as completed Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants