Upgrade babashka.curl, babashka.fs, and deps-new
#67
+18
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rads Instead of testing through the generated script, we might just test through the |
borkdude
reviewed
Aug 3, 2022
borkdude
reviewed
Aug 3, 2022
That all sounds reasonable to me. Is it OK if we take care of that in follow-up PRs? |
|
Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #66.
It might be better to structure the tests so we can run all the tests in both Babashka and Clojure. Since that will require more effort, I just did one test for now. The current test will at least ensure that the command is always runnable in Clojure.