Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new :cmd opt to exec #125

Closed
lread opened this issue May 12, 2023 · 3 comments · Fixed by #134
Closed

Add new :cmd opt to exec #125

lread opened this issue May 12, 2023 · 3 comments · Fixed by #134

Comments

@lread
Copy link
Contributor

lread commented May 12, 2023

Background

Recently the :cmd opt was added to process functions.
Nice new feature!

Problem

It would be good, for consistency, to also have :cmd opt work for exec fn.

Next Steps

I'll follow up with a PR.
@borkdude
Copy link
Contributor

Thanks!

@borkdude
Copy link
Contributor

This is already fixed with your PR or not?

@lread
Copy link
Contributor Author

lread commented May 27, 2023

No, but I think you maybe fixed it with 3f093b7.
I'll create a PR to add a test and update the exec docstring.

lread added a commit to lread/process that referenced this issue May 27, 2023
@lread
Ensure exec supports :cmd opt
132a2ca 
I think this was fixed by 3f093b7.

Added test and updated docstring.

Closes babashka#125
@lread lread mentioned this issue May 27, 2023
Merged
borkdude pushed a commit that referenced this issue May 27, 2023
@lread
Ensure exec supports :cmd opt (#134)
d47cb0b 
I think this was fixed by 3f093b7.

Added test and updated docstring.

Closes #125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure exec supports :cmd opt lread/process
2 participants
@borkdude @lread