Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case now checks :string instead of defaulting #45

Merged
merged 1 commit into from
Jul 23, 2021

Conversation

nha
Copy link
Contributor

@nha nha commented Jul 23, 2021

Following the discussion on slack.

The only keyword values allowed are :string and :inherit.
:inherit is explicitly not allowed when calling copy so it seems safe to constrain it

out (if (and out (not (identical? :inherit out)))
(future (copy stdout out out-enc))
stdout)
err (if (and err (not (identical? :inherit err)))
(future (copy stderr err err-enc))
stderr)]

@borkdude borkdude merged commit 4fdf33c into babashka:master Jul 23, 2021
@nha nha deleted the feature/fix-case-only-string branch July 23, 2021 15:48
@nha nha restored the feature/fix-case-only-string branch July 23, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants