Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for with-redefs #325

Closed
cldwalker opened this issue May 8, 2020 · 2 comments
Closed

Support for with-redefs #325

cldwalker opened this issue May 8, 2020 · 2 comments

Comments

@cldwalker
Copy link

Hi. I see #175 and #176 attempted to implement with-redefs but then disabled it. It would be awesome to include it for babashka given how powerful a testing tool it is

Is your feature request related to a problem? Please describe.
I'm looking to writing tests in babashka that use with-redefs. I'd also like to pull in this testing library which relies on with-redefs

Describe the solution you'd like
A working with-redefs

Describe alternatives you've considered
I'm not aware of alternatives to this core fn

Additional context
If you describe what's needed to make this work, perhaps someone can help with this. I could try to take a shot at it some day

Cheers

@liquidz
Copy link

liquidz commented May 8, 2020

I've wrote a macro with features similar to with-redefs for babashka, but it would be more happy to support officially :)
https://github.com/liquidz/vim-iced/blob/64a15c893c0a92f9a33927100ee09872e5d21c3e/test/clj/command/iced/core_test.clj#L8-L14

@borkdude borkdude added this to To do in Global board via automation May 8, 2020
borkdude added a commit that referenced this issue May 8, 2020
@borkdude borkdude closed this as completed May 8, 2020
Global board automation moved this from To do to Done May 8, 2020
@cldwalker
Copy link
Author

Look forward to trying this. Thanks!

bbss pushed a commit to bbss/sci that referenced this issue Aug 18, 2020
@borkdude borkdude removed this from Done in Global board Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants