Metadata contains :sci.impl/op key

[mk]

version
master at e837435

problem
Extra :sci.impl/op key on metadata.

repro

(sci/eval-string "(meta ^:m {:foo {}})")
;;=> {:m true, :sci.impl/op :eval} 

---

Changed description after #555 (comment), original issue here for context:
version
0.2.4 and master at e837435

problem
Metadata isn't preserved correctly on e.g. nested maps.

repro

(sci/eval-string "(meta ^:m {:foo :bar})") ;; => {:m true}  
(sci/eval-string "(meta ^:m {:foo {}})") ;; => nil

[mk]

I've added a failing test to illustrate the problem in 01c734f. Feel free to cherry-pick it in case you want to look at a fix, I might get around to looking more into this later today or tomorrow.

[borkdude]

@mk I'm getting:

user=> (sci/eval-string "(meta ^:m {:foo {}})")
{:m true, :sci.impl/op :eval}

on master (the :sci.impl/op :eval should probably not be there).

[borkdude]

Is this on CLJS or CLJ?

[borkdude]

OK, can reproduce by adding the failing tests, to branch: issue-555-meta-nested-maps

[borkdude]

@mk Note that these tests do pass:

(testing "meta on nested maps"
    (is (:m (eval* "(meta ^:m {:foo :bar})")))
    (is (:m (eval* "(meta ^:m {:foo {}})"))))

so although there is an extra key, I can't reproduce your original issue.

[mk]

You're right, I'm just able to reproduce the behavior as above under 0.2.3 and 0.2.4 (like seen below) but not on master. I thought master was broken because of the test failure but it only failed because of the :sci.impl/op key like you've written above.

I've bisected and identified baf61ab as the commit that fixed it. So I think this can be closed as a duplicate of #546.

Do you want me to maybe create an extra issue for removing the :sci.impl/op key from metadata?

[borkdude]

Let's just change the title of this issue... done. Feel free to update the original post.

[borkdude]

@mk Fixed!

[mk]

@borkdude thank you!