Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS try/catch is more dynamic than Clojure #584

Closed
borkdude opened this issue Jul 2, 2021 · 0 comments
Closed

JS try/catch is more dynamic than Clojure #584

borkdude opened this issue Jul 2, 2021 · 0 comments

Comments

@borkdude
Copy link
Collaborator

borkdude commented Jul 2, 2021

E.g. (try 1 (catch (if (odd? 3) js/Number js/Error) e 2))
Instead of resolving the class at analysis time, we should probably just eval the expression after the catch and then bind it?
The resolving now is also special cased on "js" which is probably wrong if you explicitly use the {:classes {'js js/window}} option.

borkdude added a commit that referenced this issue Jul 3, 2021
@borkdude borkdude closed this as completed Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant