Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js literal with expression doesn't eval expression #610

Closed
borkdude opened this issue Sep 4, 2021 · 2 comments
Closed

js literal with expression doesn't eval expression #610

borkdude opened this issue Sep 4, 2021 · 2 comments

Comments

@borkdude
Copy link
Collaborator

borkdude commented Sep 4, 2021

See babashka/nbb#57

@borkdude
Copy link
Collaborator Author

borkdude commented Sep 6, 2021

There is one thing left in this issue: currently we use clj->js and js->clj to convert between values, but these functions do a walk on the entire structure while #js only promises to do one level, so we should fix that compatibility.

@borkdude
Copy link
Collaborator Author

Currently #js also coerces values into JS objects, not good:

$ nbb -e '#js {:a :b}'
#js {:a "b"}

borkdude added a commit that referenced this issue Sep 30, 2021
borkdude added a commit that referenced this issue Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant