-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend protocols to JS built ins using CLJS "type symbols", fix extending protocols to default & Object #784
Extend protocols to JS built ins using CLJS "type symbols", fix extending protocols to default & Object #784
Conversation
src/sci/impl/protocols.cljc
Outdated
:cljs (or (= 'object sym) | ||
(= 'default sym)))) | ||
:cljs (= ::extend-default sym))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
even in the impl before this PR, this would AFAICT never happen because it wasn't possible to extend a protocol to either 'default
or 'object
simplifies the code when extending the protocol impls, and also fixes the problem with extending to Object in clojure not returning true for satisfies?
@lilactown I tried this with this PR checked out locally:
|
@borkdude I think that's due to another bug - that
And just to show that this isn't a regression, testing
|
Created #785 to track the bug with satisfies? + no methods |
Thanks! |
Please answer the following questions and leave the below in as part of your PR.
Fixes #781, #782 and #783