Merge pull request #26 from babbel/add-selected-engine-version

Allow setting workgroup's engine version
babbel · Mar 13, 2023 · 4e8bfb5 · 4e8bfb5
2 parents 28b1530 + f6181b8
commit 4e8bfb5
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## v2.1.0
+
+- [Add selected_engine_version](https://github.com/babbel/terraform-aws-athena/pull/26)
+
 ## v2.0.2
 
 - [Create S3 lifecycle config with empty filter](https://github.com/babbel/terraform-aws-athena/pull/21)

diff --git a/README.md b/README.md
@@ -25,6 +25,7 @@ module "alb-athena-example" {
     app = "example"
     env = "production"
   }
+
   resource_specific_tags = {
     s3_bucket = {
       owner = "athena"

diff --git a/_test/main.tf b/_test/main.tf
@@ -3,13 +3,13 @@ provider "aws" {
 }
 
 module "athena" {
-  source  = "./.."
+  source = "./.."
 
   name                    = "alb-logs-example-production"
   workspace_bucket_prefix = "athena-workgroup"
-  
+
   tags = {
-    app  = "some-service"
-    env  = "production"
+    app = "some-service"
+    env = "production"
   }
 }
diff --git a/main.tf b/main.tf
@@ -62,6 +62,10 @@ resource "aws_athena_workgroup" "this" {
     enforce_workgroup_configuration    = true
     publish_cloudwatch_metrics_enabled = false
 
+    engine_version {
+      selected_engine_version = var.selected_engine_version
+    }
+
     bytes_scanned_cutoff_per_query = var.workspace_bytes_scanned_cutoff
 
     result_configuration {

diff --git a/variables.tf b/variables.tf
@@ -12,6 +12,12 @@ variable "resource_specific_tags" {
   default = {}
 }
 
+variable "selected_engine_version" {
+  default = "AUTO"
+
+  description = "The work group's engine version."
+}
+
 variable "tags" {
   description = "Map of tags to assign to all resources supporting tags."