Merge pull request #6 from babbel/errors-improvement

Improved error and made client pass to be a reference
babbel · May 10, 2019 · 32de526 · 32de526
2 parents afc646d + 78cd81e
commit 32de526
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/codeclimate/data_source_repository.go b/codeclimate/data_source_repository.go
@@ -25,7 +25,7 @@ func dataSourceRepository() *schema.Resource {
 func dataSourceRepositoryRead(d *schema.ResourceData, client interface{}) error {
 	repositorySlug := d.Get("repository_slug").(string)
 
-	c := client.(codeclimateclient.Client)
+	c := client.(*codeclimateclient.Client)
 	repository, err := c.GetRepository(repositorySlug)
 	if err != nil {
 		return err

diff --git a/codeclimate/provider.go b/codeclimate/provider.go
@@ -30,5 +30,5 @@ func configureProvider(d *schema.ResourceData) (interface{}, error) {
 		BaseUrl: codeClimateApiHost,
 	}
 
-	return client, nil
+	return &client, nil
 }
diff --git a/codeclimateclient/repository.go b/codeclimateclient/repository.go
@@ -35,7 +35,14 @@ func (client *Client) GetRepository(repositorySlug string) (*Repository, error)
 		return nil, err
 	}
 
-	// TODO: check size of data
+	numberOfReposFound := len(repositoryData.Data)
+
+	if numberOfReposFound != 1 {
+		return nil, fmt.Errorf(
+			"The response for %s returned %v repositories (should have been 1)",
+			repositorySlug, numberOfReposFound,
+		)
+	}
 
 	repository := &Repository{
 		Id:             repositoryData.Data[0].ID,