feat(test-numbers): only use numbers for tests without titles #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was super annoying. Any time I added/moved/removed a test, all the snapshots would need updating because the title for every one of them changed. Pretty annoying. So now we only use the number for untitled tests and we only increment it for the untitled tests.
kentcdodds
force-pushed
the
pr/full-title
branch
from
c8a4e03
to
0d74500
Compare
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 104 105 +1
Branches 24 24
=====================================
+ Hits 104 105 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was super annoying. Any time I added/moved/removed a test, all the
snapshots would need updating because the title for every one of them
changed. Pretty annoying. So now we only use the number for untitled
tests and we only increment it for the untitled tests.
This is going to be a major version bump.