Skip to content
This repository has been archived by the owner on Aug 18, 2021. It is now read-only.

Externalize acorn-to-esprima? #24

Closed
nzakas opened this issue Mar 3, 2015 · 5 comments
Closed

Externalize acorn-to-esprima? #24

nzakas opened this issue Mar 3, 2015 · 5 comments
Labels

Comments

@nzakas
Copy link

nzakas commented Mar 3, 2015

Would you be open to publishing acorn-to-esprima as it's own package? I had something like this half done and would love to just drop it and use what you have. I think it would be useful for a number of tools that would like to support both acorn and esprima.

@sebmck
Copy link
Contributor

sebmck commented Mar 4, 2015

Sure, the only thing I see being useful is the token conversion and that's only a handful of lines though. The actual AST transformation code completely destroys the AST and just turns nodes that ESLint doesn't like into nodes that it'll happily digest.

@hzoo
Copy link
Member

hzoo commented May 15, 2015

Yeah sounds good - then wouldn't have to copy/paste similar changes between this and babel-jscs.

If we do this we could move to a more extensive test suite then we have now? It would be cool to be able to run esprima/acorn's tests and check if the ASTs are the same see how close we can get? Not sure how that would work, I suppose with a git submodule? It would be similar to #62 I think - running all of ESLint's tests with babel-eslint.

@hzoo
Copy link
Member

hzoo commented Jul 10, 2015

Made the repo - https://github.com/babel/acorn-to-esprima. Will be moving it over later

@hzoo hzoo closed this as completed Jul 10, 2015
@hzoo
Copy link
Member

hzoo commented Aug 25, 2015

@nzakas took a long time but I released https://github.com/babel/acorn-to-esprima. And probably need to be changed for other projects to use it better.

@nzakas
Copy link
Author

nzakas commented Aug 31, 2015

Thanks, I'll take a look.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants