Add tests for strict rule

[jmm]

Ref #228. These are failing now. With babel/acorn-to-esprima#5, $ npm test passes, including these.

[hzoo]

Sigh npm 2 issues not sure why that is happening now.

[jmm]

Sorry, I'm not sure what you mean.

[hzoo]

The travis build is failing with everything but node 5 (npm 3). Error: Cannot find module 'estraverse'

[jmm]

Ahh, ok, thanks. I didn't even look because I expected it to fail when I submitted the PR.

[hzoo]

The dependencies didn't change either - I guess something about the test/integration.js is making it error (although that is weird)

[hzoo]

Oh because you are using the eslint git submodule instead of var eslint = require("eslint"); probably

[jmm]

Hmm, did I require eslint wrong?

[jmm]

Sorry, posted before I saw your latest comment. I'm fuzzy on the details of how eslint is integrated here (e.g. why it's submodule). So it should just be require("eslint")?

[hzoo]

Yeah just require it using node_modules.

I was planning on using the submodule for testing all their rules with the parser but was having issues (feel free to look into that as well). https://github.com/babel/babel-eslint/blob/master/package.json#L19-L20

If you look at the other tests/ they use the eslint in the package.json/node_modules (like you normally would).

Sorry that's not more obvious (there's no docs about any of this)

[jmm]

Ok, done ✨. Sorry about that. I do see that's how the other test file does it -- overlooked that somehow. As you said, some more high-level docs would be helpful too.

I was planning on using the submodule for testing all their rules with the parser but was having issues (feel free to look into that as well).

Oh, ok, thanks.

[jmm]

Looks like it's now just failing on 0.12 for something unrelated.

[hzoo]

Ah yeah that test - will fix (or skip for now). Ok the funny part is that it's skipped but it still fails