This repository has been archived by the owner on Aug 18, 2021. It is now read-only.
Update ESLint config #706
Merged
Update ESLint config #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaicataldo
commented
Oct 27, 2018
| @@ -0,0 +1 @@ | |||
| package-lock = false | |||
There was a problem hiding this comment.
This is to prevent the creation of a package-lock.json file in the event someone uses npm i
kaicataldo
commented
Oct 27, 2018
| "no-var": 0, | ||
| "max-len": 0, | ||
| "max-len": "off", | ||
| "strict": "error", |
There was a problem hiding this comment.
I noticed some files were using directives and some weren't, and I'm assuming we want to be in strict mode for all files.
kaicataldo
commented
Oct 27, 2018
| } | ||
| }, | ||
| parserOptions: { | ||
| sourceType: "script", |
There was a problem hiding this comment.
Needed to override https://github.com/babel/eslint-config-babel/blob/master/index.js#L7 for the strict rule.
kaicataldo
commented
Oct 27, 2018
| { | ||
| files: ["test/**/*"], | ||
| env: { | ||
| mocha: true |
There was a problem hiding this comment.
Scoping this env just to tests so that we don't accidentally use these globals in the source code.
existentialism
approved these changes
Oct 29, 2018
nicolo-ribaudo
pushed a commit
to babel/babel
that referenced
this pull request
Nov 14, 2019
Update ESLint config
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking to pick up #594 again and saw a few things that I thought should be updated in a separate PR.