-
-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use of sourceMap alias of sourceMaps. #658
Comments
kevinji
added a commit
to kevinji/Reddit-Enhancement-Suite
that referenced
this issue
Aug 30, 2018
erikdesjardins
pushed a commit
to honestbleeps/Reddit-Enhancement-Suite
that referenced
this issue
Aug 30, 2018
* Upgrade Babel to 7.0 * use loose mode in tranforms to avoid unnecessary helpers * package.json: Update ava to 1.0.0-beta.8 * ava: Use t.throwsAsync for async exceptions * Move config to babel.config.js, and add @babel/preset-env support * eslint: Upgrade to fix build error, and disable warnings * eslint: Upgrade plugins * babel: Remove sourceMaps option, as it conflicts with babel-loader See babel/babel-loader#658. * Revert "babel: Remove sourceMaps option, as it conflicts with babel-loader" This reverts commit b1aabb0 * Revert "Move config to babel.config.js, and add @babel/preset-env support" This reverts commit 9c1e197 * define methods on the prototype instead of own properties for desired subclass implementations Babel 7 is more spec compliant, in that it always assigns `undefined` to an own property for each undefined object property; since these methods are meant to be defined on the prototype, this always overrides the implementation with undefined.
this extra sourceMap:true in presets in babel options is coming from dependent library being used inside our project, thanks for all of your time for analyzing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
babel-loader uses the
sourceMaps
option alias ofsourceMap
which will cause a validation fail if a user tries to use the documentedsourceMaps
option (instead of thesourceMap
alias) because it says both cannot be used.The text was updated successfully, but these errors were encountered: