Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of sourceMap alias of sourceMaps. #658

Closed
jdalton opened this issue Aug 16, 2018 · 2 comments
Closed

Use of sourceMap alias of sourceMaps. #658

jdalton opened this issue Aug 16, 2018 · 2 comments

Comments

@jdalton
Copy link
Member

jdalton commented Aug 16, 2018

babel-loader uses the sourceMaps option alias of sourceMap which will cause a validation fail if a user tries to use the documented sourceMaps option (instead of the sourceMap alias) because it says both cannot be used.

kevinji added a commit to kevinji/Reddit-Enhancement-Suite that referenced this issue Aug 30, 2018
erikdesjardins pushed a commit to honestbleeps/Reddit-Enhancement-Suite that referenced this issue Aug 30, 2018
* Upgrade Babel to 7.0

* use loose mode in tranforms to avoid unnecessary helpers

* package.json: Update ava to 1.0.0-beta.8

* ava: Use t.throwsAsync for async exceptions

* Move config to babel.config.js, and add @babel/preset-env support

* eslint: Upgrade to fix build error, and disable warnings

* eslint: Upgrade plugins

* babel: Remove sourceMaps option, as it conflicts with babel-loader

See babel/babel-loader#658.

* Revert "babel: Remove sourceMaps option, as it conflicts with babel-loader"

This reverts commit b1aabb0

* Revert "Move config to babel.config.js, and add @babel/preset-env support"

This reverts commit 9c1e197

* define methods on the prototype instead of own properties for desired subclass implementations

Babel 7 is more spec compliant, in that it always assigns `undefined` to an own property for each undefined object property;
since these methods are meant to be defined on the prototype, this always overrides the implementation with undefined.
@revurirams123
Copy link

revurirams123 commented Feb 14, 2019

Hi I am not using sourceMap in my babel.config.js however i have used it in webpack.config.js for devtool and for loaders like css-loader, sass-loader ..etc , I tried all possibilities replacing sourceMap to sourceMaps it is not helping. can you please help how to fix this .
My babel.config.js is as below:
image

And my webpack.config.js (splitted into two screenshots) is as below
image
image

@revurirams123
Copy link

this extra sourceMap:true in presets in babel options is coming from dependent library being used inside our project, thanks for all of your time for analyzing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants