Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to webpack 3 #471

Merged
merged 1 commit into from
Jun 20, 2017
Merged

Update to webpack 3 #471

merged 1 commit into from
Jun 20, 2017

Conversation

lencioni
Copy link
Contributor

@lencioni lencioni commented Jun 19, 2017

Now that webpack 3 is out, I am bumping some versions in here
so folks can update. I don't know if any other changes are required
but I figured I'd get the ball rolling.

Please Read the CONTRIBUTING Guidelines
In particular the portion on Commit Message Formatting

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: Updating dependencies

What is the current behavior? (You can also link to an open issue here)

Could not update to webpack 3

What is the new behavior?

Can update to webpack 3

Does this PR introduce a breaking change?

  • Yes
  • No

If this PR contains a breaking change, please describe the following...

  • Impact:
  • Migration path for existing applications:
  • Github Issue(s) this is regarding:

N/A

Other information:
This may require additional changes, I'm not sure.

Now that webpack 3 is out, I am bumping some versions in here
so folks can update. I don't know if any other changes are required
but I figured I'd get the ball rolling.
@codecov
Copy link

codecov bot commented Jun 19, 2017

Codecov Report

Merging #471 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #471   +/-   ##
=======================================
  Coverage   79.44%   79.44%           
=======================================
  Files           6        6           
  Lines         180      180           
  Branches       47       47           
=======================================
  Hits          143      143           
  Misses         17       17           
  Partials       20       20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8544ffa...856a55a. Read the comment docs.

@danez
Copy link
Member

danez commented Jun 20, 2017

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants