Update to latest babel version and fix babelrc behaviour #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the custom behaviour in babel-loader of the option `babelrc`. It now cannot be a string anymore and should be boolean and instead extends should be used. BREAKING CHANGE: Option `babelrc` needs to be boolean now. String values are not allowed anymore. Use `extends` option to specify a specific config file. A warning will be triggered when setting babelrc to a string.
|
@loganfsmyth It would be nice if babel-core could somehow expose which config files are used for a specific source file. That way we wouldn't have to do the resolve of the babelrc files in the loader. |
danez
commented
Feb 25, 2018
test/cache.test.js
Outdated
| @@ -288,7 +300,8 @@ test.cb("should allow to specify the .babelrc file", t => { | |||
| exclude: /node_modules/, | |||
| query: { | |||
| cacheDirectory: t.context.cacheDirectory, | |||
| babelrc: path.join(__dirname, "fixtures/babelrc"), | |||
| extends: path.join(__dirname, "fixtures/babelrc"), | |||
| babelrc: false, | |||
There was a problem hiding this comment.
This is the breaking change basically, I couldn't figure out why we used a string value for babelrc in the first place.
This was referenced Feb 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the custom behaviour in babel-loader of the option
babelrc. It now cannot be a string anymore and should be boolean and insteadextendsshould be used.BREAKING CHANGE: Option
babelrcneeds to be boolean now. String values are not allowed anymore. Useextendsoption to specify a specific config file. A warning will be triggered when setting babelrc to a string.