This repository has been archived by the owner on May 11, 2018. It is now read-only.
Support target versions as strings #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
existentialism
force-pushed
the
issue187
branch
from
5cfd3b4
to
0e43108
Compare
|
Maybe semverify all targets' versions immediately? If there are no difference between '5' and 5, why we should log it as a different values? Also it would be good for the |
|
"Few" more changes:
|
existentialism
force-pushed
the
issue187
branch
3 times, most recently
from
3de93ac
to
9f0f104
Compare
Codecov Report
@@ Coverage Diff @@
## 2.0 #231 +/- ##
======================================
Coverage ? 94.61%
======================================
Files ? 6
Lines ? 223
Branches ? 64
======================================
Hits ? 211
Misses ? 9
Partials ? 3
Continue to review full report at Codecov.
|
existentialism
commented
Mar 30, 2017
| @@ -245,20 +245,22 @@ const generateData = (environments, features) => { | |||
| environments.forEach(env => { | |||
| const version = getLowestImplementedVersion(options, env); | |||
| if (version !== null) { | |||
| plugin[env] = version; | |||
| plugin[env] = version.toString(); | |||
There was a problem hiding this comment.
Should we semverify these?
existentialism
force-pushed
the
issue187
branch
3 times, most recently
from
c3a0e75
to
223ae49
Compare
existentialism
force-pushed
the
issue187
branch
2 times, most recently
from
259215a
to
6d32f1d
Compare
yavorsky
approved these changes
Apr 7, 2017
hzoo
approved these changes
Apr 7, 2017
This was referenced Apr 11, 2017
Merged
existentialism
added a commit
that referenced
this pull request
May 10, 2017
existentialism
added a commit
that referenced
this pull request
May 10, 2017
existentialism
added a commit
that referenced
this pull request
May 19, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of #187.
Wanted to keep it relatively small, so only the following changes:
semverifyand moved_extendto utils file ala [WIP] Add node's "engines" option #114build-datanow outputs string values for env versionssemverto check if a plugin is required"node": 6.9and target"node": 6.10will behave differently) with numeric target versions, not sure if we should drop in 2.0?We should follow this up with #114 then possibly add range support to targets (
"chrome": "^52") if we want.